-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update getting-started.md #471
Conversation
Added instructions for Windows users. Made use of the inbuilt certutil command to do the base64 decoding.
@sameersbn would you have some time to test out these instructions on Windows? |
docs/user/getting-started.md
Outdated
``` | ||
For Linux: | ||
|
||
```bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to move the following two commands outside the platform specific instructions right?
kubectl create serviceaccount kubeapps-operator
kubectl create clusterrolebinding kubeapps-operator --clusterrole=cluster-admin --serviceaccount=default:kubeapps-operator
docs/user/getting-started.md
Outdated
kubectl create serviceaccount kubeapps-operator | ||
kubectl create clusterrolebinding kubeapps-operator --clusterrole=cluster-admin --serviceaccount=default:kubeapps-operator | ||
kubectl get secret $(kubectl get serviceaccount kubeapps-operator -o jsonpath='{.secrets[].name}') -o jsonpath='{.data.token}' | base64 --decode | ||
``` | ||
For Windows: | ||
|
||
Create a file called GetDashToken.cmd with the following lines in it: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please format instances of GetDashToken.cmd as GetDashToken.cmd
docs/user/getting-started.md
Outdated
REM Decode The Token | ||
DEL token.txt | ||
certutil -decode b64.txt token.txt | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove this extra new-line character
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@natiki I think you still need to remove this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah I saw your comment about readability, we can leave it in
docs/user/getting-started.md
Outdated
certutil -decode b64.txt token.txt | ||
|
||
``` | ||
Open a command prompt and run the GetDashToken.cmd Your token can be found in the token.txt file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the missing period .
docs/user/getting-started.md
Outdated
|
||
Create a file called GetDashToken.cmd with the following lines in it: | ||
|
||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use bat
to apply syntax highlighting to this block
f.e.
REM my comment
DEL s.txt
ping @natiki |
@sameersbn. I applied all your changes except for removing the blank lines in the batch file as I believe they add readability. If you really want them out then feel free to take them out.
ping @sameersbn |
Added instructions for Windows users. Made use of the inbuilt certutil command to do the base64 decoding.